<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    On 16/10/15 10:46, Jonas Lindert wrote:
    <blockquote cite="mid:5620C75B.1080903@physik.uzh.ch" type="cite">Hi
      Andy,
      <br>
      <br>
      attached you find a yoda file with a 2D Histogram (and the result
      I get with rivet-cmphistos).
      <br>
    </blockquote>
    Hi Jonas,<br>
    <br>
    this is a bit hard to debug. Could you please tell me what
    shape/plot you would expect?<br>
    <br>
    I attached the plot I get from you yoda file when setting LogZ=1.<br>
    <br>
    Maybe we can use that as a basis for discussion.<br>
    <br>
    Thanks,<br>
    Holger<br>
    <blockquote cite="mid:5620C75B.1080903@physik.uzh.ch" type="cite">
      <br>
      cheers,
      <br>
      Jonas
      <br>
      <br>
      <br>
      <br>
      <br>
      On 10/16/15 11:05, Andy Buckley wrote:
      <br>
      <blockquote type="cite">Hi Jonas,
        <br>
        <br>
        Could you send us a .yoda file with your 2D histogram in it, and
        we'll do some testing / bugfixing? Thanks.
        <br>
        <br>
        Andy
        <br>
        <br>
        <br>
        On 15/10/15 23:56, Jonas Lindert wrote:
        <br>
        <blockquote type="cite">Hi Andy,
          <br>
          <br>
          i’ve got another Problem with 2D Histograms. This time on the
          yoda side.
          <br>
          The histogram rivet-cmphistos produces for a 2D yoda does not
          seem to be
          <br>
          correct.
          <br>
          <br>
          Look at the attached yoda file and the resulting dat-file from
          <br>
          rivet-cmphistos. The shape of the two histograms is completely
          different.
          <br>
          <br>
          cheers,
          <br>
          Jonas
          <br>
          <br>
          <br>
          <br>
          <br>
          <br>
          <br>
          <br>
          <br>
          <blockquote type="cite">On 15 Oct 2015, at 01:33, Jonas
            Lindert <<a class="moz-txt-link-abbreviated" href="mailto:lindert@physik.uzh.ch">lindert@physik.uzh.ch</a>
            <br>
            <a class="moz-txt-link-rfc2396E" href="mailto:lindert@physik.uzh.ch"><mailto:lindert@physik.uzh.ch></a>> wrote:
            <br>
            <br>
            Hi Andy,
            <br>
            <br>
            thanks a lot - this seems to work!
            <br>
            <br>
            I will let you know if I have further issues with 2D
            histograms.
            <br>
            <br>
            cheers,
            <br>
            Jonas
            <br>
            <br>
            <br>
            <br>
            <blockquote type="cite">On 14 Oct 2015, at 16:05, Andy
              Buckley <<a class="moz-txt-link-abbreviated" href="mailto:andy.buckley@cern.ch">andy.buckley@cern.ch</a>
              <br>
              <a class="moz-txt-link-rfc2396E" href="mailto:andy.buckley@cern.ch"><mailto:andy.buckley@cern.ch></a>> wrote:
              <br>
              <br>
              Hi Jonas,
              <br>
              <br>
              Hmm, this does seem to be a bug. I'm not sure how the
              compiler
              <br>
              allowed a method of Analysis to be declared but never
              defined, but
              <br>
              that's what happened. In the development trunk I have
              added the lines
              <br>
              below to src/Core/Analysis.cc
              <a class="moz-txt-link-rfc2396E" href="http://analysis.cc/"><http://analysis.cc/></a>-- feel free to do
              <br>
              the same to your local copy, and let us know if it works!
              <br>
              <br>
              This will go into the next patch release. Thanks for the
              report, and
              <br>
              please let us know if you have any more trouble with 2D
              histograms
              <br>
              since until recently they haven't been used much in
              Rivet/YODA.
              <br>
              <br>
              <br>
              Patch:
              <br>
              ----
              <br>
              <br>
               void Analysis::normalize(Histo2DPtr histo, double norm,
              bool
              <br>
              includeoverflows) {
              <br>
                 if (!histo) {
              <br>
                   MSG_ERROR("Failed to normalize histo=NULL in analysis
              " <<
              <br>
              name() << " (norm=" << norm << ")");
              <br>
                   return;
              <br>
                 }
              <br>
                 MSG_TRACE("Normalizing histo " <<
              histo->path() << " to " << norm);
              <br>
                 try {
              <br>
                   histo->normalize(norm, includeoverflows);
              <br>
                 } catch (YODA::Exception& we) {
              <br>
                   MSG_WARNING("Could not normalize histo " <<
              histo->path());
              <br>
                   return;
              <br>
                 }
              <br>
               }
              <br>
              <br>
              <br>
               void Analysis::scale(Histo2DPtr histo, double scale) {
              <br>
                 if (!histo) {
              <br>
                   MSG_ERROR("Failed to scale histo=NULL in analysis "
              << name() <<
              <br>
              " (scale=" << scale << ")");
              <br>
                   return;
              <br>
                 }
              <br>
                 if (std::isnan(scale) || std::isinf(scale)) {
              <br>
                   MSG_ERROR("Failed to scale histo=" <<
              histo->path() << " in
              <br>
              analysis: " << name() << " (invalid scale
              factor = " << scale << ")");
              <br>
                   scale = 0;
              <br>
                 }
              <br>
                 MSG_TRACE("Scaling histo " << histo->path()
              << " by factor " <<
              <br>
              scale);
              <br>
                 try {
              <br>
                   histo->scaleW(scale);
              <br>
                 } catch (YODA::Exception& we) {
              <br>
                   MSG_WARNING("Could not scale histo " <<
              histo->path());
              <br>
                   return;
              <br>
                 }
              <br>
               }
              <br>
              <br>
              ----
              <br>
              <br>
              Cheers,
              <br>
              Andy
              <br>
              <br>
              <br>
              On 14/10/15 14:45, Jonas Lindert wrote:
              <br>
              <blockquote type="cite">Dear Rivet/Yoda Developers,
                <br>
                <br>
                I have got a problem with 2D Histograms within Rivet
                2.3. In particular
                <br>
                normalizing them via
                <br>
                <br>
                scale (Histo2DPtr histo, double scale)
                <br>
                <br>
                gives:
                <br>
                <br>
                Rivet.Analysis.Handler: INFO  Finalising analyses
                <br>
                python: symbol lookup error:
                /zbox/user/lindert/rivet/RivetTwoD_test.so:
                <br>
                undefined symbol:
                <br>
_ZN5Rivet8Analysis5scaleEN5boost10shared_ptrIN4YODA7Histo2DEEEd
                <br>
                <br>
                where I use the standalone version of Rivet.
                <br>
                <br>
                Attached you find an example including an hepmc file.
                <br>
                <br>
                Am I using 2D histograms in a wrong way or is there a
                bug in Rivet/Yoda?
                <br>
                <br>
                <br>
                cheers,
                <br>
                Jonas
                <br>
                <br>
                <br>
                <br>
                <br>
                <br>
                _______________________________________________
                <br>
                Rivet mailing list
                <br>
                <a class="moz-txt-link-abbreviated" href="mailto:Rivet@projects.hepforge.org">Rivet@projects.hepforge.org</a>
                <a class="moz-txt-link-rfc2396E" href="mailto:Rivet@projects.hepforge.org"><mailto:Rivet@projects.hepforge.org></a>
                <br>
                <a class="moz-txt-link-freetext" href="https://www.hepforge.org/lists/listinfo/rivet">https://www.hepforge.org/lists/listinfo/rivet</a>
                <br>
                <br>
              </blockquote>
              <br>
              <br>
              -- <br>
              Dr Andy Buckley, Lecturer / Royal Society University
              Research Fellow
              <br>
              Particle Physics Expt Group, University of Glasgow
              <br>
            </blockquote>
            <br>
          </blockquote>
          <br>
        </blockquote>
        <br>
        <br>
      </blockquote>
      <br>
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Rivet mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Rivet@projects.hepforge.org">Rivet@projects.hepforge.org</a>
<a class="moz-txt-link-freetext" href="https://www.hepforge.org/lists/listinfo/rivet">https://www.hepforge.org/lists/listinfo/rivet</a></pre>
    </blockquote>
    <br>
  </body>
</html>