[Rivet-svn] rivet: More tidying of the ZEUS analysis... but several ill-defi...

[Rivet Mercurial]

details:   https://rivet.hepforge.org/hg/rivet/rev/30026de2c7c0
branches:  
changeset: 5277:30026de2c7c0
user:      Andy Buckley <andy at insectnation.org>
date:      Wed Jun 22 15:38:36 2016 +0100
description:
More tidying of the ZEUS analysis... but several ill-defined things needing expert input

diffs (truncated from 147 to 50 lines):

--- a/data/anainfo/ZEUS_2001_S4815815.info	Tue Jun 21 13:51:00 2016 +0100
+++ b/data/anainfo/ZEUS_2001_S4815815.info	Wed Jun 22 15:38:36 2016 +0100
@@ -6,6 +6,7 @@
 SpiresID: 4815815
 Status: UNVALIDATED
 Authors:
+ - Andy Buckley <andy.buckley at cern.ch>
  - Jon Butterworth <jmb at hep.ucl.ac.uk>
 References:
  - Eur.Phys.J.C23:615,2002
--- a/src/Analyses/ZEUS_2001_S4815815.cc	Tue Jun 21 13:51:00 2016 +0100
+++ b/src/Analyses/ZEUS_2001_S4815815.cc	Wed Jun 22 15:38:36 2016 +0100
@@ -12,25 +12,25 @@
   /// This class is a reproduction of the HZTool routine for the ZEUS
   /// dijet photoproduction paper which was used in the ZEUS jets PDF fit.
   ///
-  /// @author Jon Butterworth
+  /// @author Andy Buckley
   class ZEUS_2001_S4815815 : public Analysis {
   public:
 
     /// Constructor
-    ZEUS_2001_S4815815()
-      : Analysis("ZEUS_2001_S4815815")
-    {    }
-
+    DEFAULT_RIVET_ANALYSIS_CTOR(ZEUS_2001_S4815815);
 
     /// @name Analysis methods
     //@{
 
     // Book projections and histograms
     void init() {
-      /// @todo Force conventional event rotation with proton along +z?
+
+      /// @todo Acceptance
       FinalState fs;
+      /// @todo What kT radius? Or was this exclusive kT... with what threshold?
       declare(FastJets(fs, FastJets::KT, 0.7), "Jets");
 
+      /// @todo Dress the lepton?
       IdentifiedFinalState positrons(fs, PID::POSITRON);
       declare(positrons, "Positrons");
 
@@ -70,34 +70,46 @@
     // Do the analysis
     void analyze(const Event& event) {
 
+      // Determine event orientation, since coord system is for +z = proton direction
+      const ParticlePair bs = event.beams();