[Rivet] [Rivet-svn] r2130 - in trunk: . bin include/Rivet pyext src/Core

Frank Siegert frank.siegert at durham.ac.uk
Sat Dec 5 14:08:17 GMT 2009


I have a question/comment about this commit:

blackhole at projects.hepforge.org, Wednesday 02 December 2009:
> Author: buckley
> Date: Wed Dec  2 16:37:20 2009
> New Revision: 2130
> 
> Log:
> Restructuring of Run, and making first event sqrt(s) and beams
>  accessible from later in the run via the AnalysisHandler. Requires a
>  Python build dir deletion since Python-facing Run and AnalysisHandler
>  APIs have changed.
> 
> Modified:
>    trunk/ChangeLog
>    trunk/bin/rivet
>    trunk/include/Rivet/AnalysisHandler.hh
>    trunk/include/Rivet/Run.hh
>    trunk/pyext/rivet.i
>    trunk/src/Core/AnalysisHandler.cc
>    trunk/src/Core/Run.cc

The sqrts/beam info is now being extracted by Run.cc and passed into 
AnalysisHandler from there. This means, that interfaces to Rivet will 
break, because until now everything relevant for initialisation of the 
analyses happened in AnalysisHandler. Now it will also be necessary for 
each interface to Rivet to extract the sqrts/beam information themselves 
and pass them into the AnalysisHandler. I assume this will be pretty 
difficult, because these methods didn't exist in Rivet <1.2.0, so whenever 
an interface is updated, it won't compile with older versions of Rivet 
anymore.

Would it be possible, to leave the parsing of the first event in 
AnalysisHandler in any way? I know why you moved it, because you needed 
the first event before doing the analyses init. But maybe that could be 
done by having AnalysisHandler extract the information and call the 
analysis init in an "if (firstevent)" block within 
AnalysisHandler::analyze?

What do you think?

Frank


More information about the Rivet mailing list