[Rivet] aida2root

[Ben Waugh]

Hi Andy, All,

Looks like this fix, and the clearer warning message, has got lost 
somewhere along the way, since the tagged release rivet-1.1.3 has
  os.has_key("ROOTSYS")
instead of
  if os.environ.has_key("ROOTSYS")
in aida2root.

Can it please be fixed again in the next tagged version?

Cheers,
Ben

On 08/07/09 12:40, Andy Buckley wrote:
> Emily Nurse wrote:
>> Dear Riveters,
>>
>> We are having problems converting aida files to ROOT files on the UCL  
>> hep cluster. The problem is in the way PyROOT is installed so is  
>> obviously a UCL problem but along the way we saw a couple of other  
>> problems with the aida2root script.
>>
>> Firstly should the line:
>>
>> if os.has_key("ROOTSYS")
>>
>> actually be
>>
>> if os.environ.has_key("ROOTSYS")
>> ?
> 
> Thanks. I fixed that in SVN earlier today, when James drew my attention 
> to it. Update the code and you'll get the fix.
> 
>> Secondly we find the warning message:
>>
>> "Couldn't find ROOT module. If ROOT is installed, you probably have  
>> PyROOT installed as well."
>>
>> confusing, what is this trying to tell us? That it can't find either  
>> ROOT or PyROOT?
> 
> The confusion is because PyROOT is imported as a module called "ROOT"... 
> I guess that's not so clear if you haven't used it. SO what the message 
> means is "I couldn't find PyROOT... but if you have ROOT installed then 
> you probably also have PyROOT, just not set up properly. So sort your 
> system out ;)" The error message now says something along those lines, 
> only a (little) bit more polite. It also tries to guess the PyROOT path 
> and tell you what to set, if $ROOTSYS is set.
> 
> Andy
> 

-- 
Dr Ben Waugh                                   Tel. +44 (0)20 7679 7223
Dept of Physics and Astronomy                  Internal: 37223
University College London
London WC1E 6BT