[Rivet] [Rivet-svn] r2908 - trunk/src/Analyses

[Andy Buckley]

It had been validated and then I rewrote it to clean up: we used that  
analysis as an implementation exercise exercise at YETI. I knew there  
was a remaining problem with the histograms -- thanks for finding it  
-- but as none of the analysis logic had changed I hadn't marked it as  
UNVALIDATED.

While not automatically a fan of formal procedures, I think we do need  
to introduce a more formal process for analysis validation. Running  
lots of MC and regression testing before each release is one thing,  
but I think that we should require supplied analyses to be  
code-reviewed by experienced developers before they can be marked as  
VALIDATED in the first place. That's more important as we start to get  
more analyses direct from the experiments -- several have been  
spaghetti code that achieve their objectives in extremely silly ways.  
We should aim to keep the standard and style of code consistently high  
quality.

Andy

PS. My laptop died in a boot-up kernel-panic way last night, and I'm  
trying to back-up data and reinstall / fix the problem today. I have  
some crappy web mail access, but in general will probably be quite  
unresponsive. D'oh.


Quoting Frank Siegert <frank.siegert at cern.ch>:

> Stupid question: How was this analysis VALIDATED given that it  
> always crashed?
> I'm asking to find out whether it is indeed somehow validated or  
> whether validation is still necessary, because I wanted to use it.
>
> Cheers,
> Frank
>
> On 02/02/11 12:07, blackhole at projects.hepforge.org wrote:
>> Author: fsiegert
>> Date: Wed Feb  2 11:07:21 2011
>> New Revision: 2908
>>
>> Log:
>> Fix for crash in ATLAS_2010_S8817804: Histograms don't start at  
>> d00-x01-y01 but at d01-x01-y01.
>>
>> Modified:
>>    trunk/src/Analyses/ATLAS_2010_S8817804.cc
>>
>> Modified: trunk/src/Analyses/ATLAS_2010_S8817804.cc
>> ==============================================================================
>> --- trunk/src/Analyses/ATLAS_2010_S8817804.cc	Tue Feb  1 14:07:48  
>> 2011	(r2907)
>> +++ trunk/src/Analyses/ATLAS_2010_S8817804.cc	Wed Feb  2 11:07:21  
>> 2011	(r2908)
>> @@ -41,17 +41,17 @@
>>        size_t ptDsOffset(0), massDsOffset(10), chiDsOffset(20);
>>        for (size_t alg = 0; alg<  2; ++alg) {
>>          for (size_t i = 0; i<  5; ++i) {
>> -          _pThistos[alg].addHistogram(ybins[i], ybins[i+1],  
>> bookHistogram1D(i + ptDsOffset, 1, 1));
>> +          _pThistos[alg].addHistogram(ybins[i], ybins[i+1],  
>> bookHistogram1D(i + 1 + ptDsOffset, 1, 1));
>>          }
>>          ptDsOffset += 5;
>>
>>          for (size_t i = 0; i<  5; ++i) {
>> -          _massVsY[alg].addHistogram(ybins[i], ybins[i+1],  
>> bookHistogram1D(i + massDsOffset, 1, 1));
>> +          _massVsY[alg].addHistogram(ybins[i], ybins[i+1],  
>> bookHistogram1D(i + 1 + massDsOffset, 1, 1));
>>          }
>>          massDsOffset += 5;
>>
>>          for (size_t i = 0; i<  3; ++i) {
>> -          _chiVsMass[alg].addHistogram(massBinsForChi[i],  
>> massBinsForChi[i+1], bookHistogram1D(i + chiDsOffset, 1, 1));
>> +          _chiVsMass[alg].addHistogram(massBinsForChi[i],  
>> massBinsForChi[i+1], bookHistogram1D(i + 1 + chiDsOffset, 1, 1));
>>          }
>>          chiDsOffset += 3;
>>        }
>> @@ -100,13 +100,9 @@
>>
>>      void finalize() {
>>        for (size_t alg = 0; alg<  2; ++alg) {
>> -        //cout<<  0<<  endl;
>>          _pThistos[alg].scale(crossSectionPerEvent()/picobarn, this);
>> -        //cout<<  1<<  endl;
>>          _massVsY[alg].scale(crossSection()/_sumW/picobarn, this);
>> -        //cout<<  2<<  endl;
>>          _chiVsMass[alg].scale(crossSection()/_sumW/picobarn, this);
>> -        //cout<<  3<<  endl;
>>        }
>>      }
>>
>> _______________________________________________
>> Rivet-svn mailing list
>> Rivet-svn at projects.hepforge.org
>> http://www.hepforge.org/lists/listinfo/rivet-svn
> _______________________________________________
> Rivet mailing list
> Rivet at projects.hepforge.org
> http://www.hepforge.org/lists/listinfo/rivet
>
>



-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.