|
[Rivet] inRange troubleFrank Siegert frank.siegert at cern.chThu Sep 22 11:34:53 BST 2011
On 22/09/11 10:18, Hendrik Hoeth wrote: > Thus spake Frank Siegert (frank.siegert at cern.ch): >> On 22/09/11 09:58, Hendrik Hoeth wrote: >>> if (inRange(jetpt/GeV, 10, 15)) { ... } >> >> Isn't that wrong and should be >> if (inRange(jetpt/GeV, 10.0, 15.0)) { ... } >> ? >> With that you shouldn't run into the problems you describe below, right? > > And of course no user has or will ever put an integer value in that > function, so we are safe. I'm not sure where to place the cut of what has to be safe guarded against C++ mistakes of analysis authors, but if you and Andy agree that the above is a problem, then I'm outvoted. Is Jenkins doing anything special in the build for this warning to show up? I can't reproduce it right now. Cheers, Frank
More information about the Rivet mailing list |