[Rivet] ATLAS analysis to be included into Rivet

[Roman Lysak]

  Hi Andy,

On 12/20/2012 06:34 PM, Andy Buckley wrote:
> Hi Roman,
>
> Yes, I got the job of integrating this analysis into the release... so
> I'm writing here with my Rivet hat on ;)
>
> Thanks for the analysis. I've tidied it up a bit to fit our style
> requirements (https://rivet.hepforge.org/trac/wiki/CodingStyleGuide) a
> bit better -- lower-case variable (and function, although I didn't fix
> those yet) names, histo variables starting with _h_ (I used _hs_ for the
> arrays), using inRange, max, sqr, etc. rather than writing by hand, etc.
> I also moved the stateless functions out of the class, although that's
> not strictly necessary and I _might_ even revert it.
thanks for all the improvements.
I must admit I did not pay much attention to the coding style when I've 
got the Rivet routine from the original authors except for obvious 
improvements which improved readability of the code.
I will try to follow CodingStyleGuide more closely in the future.


> A few things
> remain, but I think nothing worth blocking this from entering our release:
>
> * The eccentricity code, obviously
>
> * There's a delta phi being written by hand -- use Rivet's deltaPhi, or
> mapAngleTo... functions instead.
fixed, see the attached code

> * There are explicit calculations of rotation matrices as 2D arrays --
> for maintainability (and possibly making these functions standard ones
> in Rivet) this should be replaced by the Rivet rotation machinery: I
> think/hope it's simple!
I will need to look at this more closely to understand this better.
However, I will be back in work only on Jan 7, so I'll be probably able 
to look at this only after then.

>
> * There are commented-out useInvisibles calls on the jets: do these jets
> *not* calibrate for neutrinos from semileptonic hadron decays? Seems
> likely, if the analysis is really on locally calibrated cluster jet
> constituents, but I just wanted to check that this is correct and then
> *really* remove those lines.
this analysis is using locally calibrated cluster jets and does not use 
neutrinos, so yes, useInvisibles should really be removed.


> * There is a cout along the lines of "things have gone wrong", in one
> calculator function... but no error handling seems to happen. Not good!
> Can you check/fix this? If it should never happen, then an assert would
> be better; if it might happen, there should be some proper error handling.
in this analysis, this should never happen so I put assert there.

Thanks a lot,
   Roman



>
> Thanks, and have a good Christmas break!
>
> Andy
>
>
> On 18/12/12 22:38, Roman Lysak wrote:
>>   Dear Rivet authors,
>>
>> we have prepared another analysis from Atlas experiment which we would
>> like to include into Rivet.
>> We validated that the routine produces consistent results comparing to
>> results in the paper. One plot (eccentricity) is unvalidated, so we
>> commented it out.
>> All necessary information can be found in the attachment.
>>
>> Please let me know if anything else is required.
>>
>> Thanks,
>>    Roman Lysak
>>
>>
>> _______________________________________________
>> Rivet mailing list
>> Rivet at projects.hepforge.org
>> http://www.hepforge.org/lists/listinfo/rivet
>>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: ATLAS_2012_I1119557.cc
Type: text/x-c++src
Size: 9622 bytes
Desc: not available
URL: <http://www.hepforge.org/lists-archive/rivet/attachments/20121227/c8099220/attachment.cc>