[Rivet] Rivet 1.8.2 - Bug Reports

[David Abdurachmanov]

Dear Rivet developers,

I have recently pulled Rivet 1.8.2 into CMSSW bundle. I would like to share a few bug reports:

(a) Duplicate symbols issue.

It's fatal on Darwin platform, yet works on SLC5 and SLC6.

BinnedHistogram.cc and libRivetTools_la-BinnedHistogram.lo is mentioned twice in src/Tools/Makefile.am making libtool to pack binary blob twice into the final static library.

Patch: http://cmssw.cvs.cern.ch/cgi-bin/cmssw.cgi/COMP/CMSDIST/rivet-1.8.2-fix-duplicate-symbols.patch?revision=1.1

(b) Ambiguous isnan/isinf calls.

Compilation is fatal on Darwin platform. You need to specify full qualified name for isnan/isinf as it could some from libstdc++v3 (e.g, std::isnan) or boost (e.g., boost::math::isnan).

Patch: http://cmssw.cvs.cern.ch/cgi-bin/cmssw.cgi/COMP/CMSDIST/rivet-1.8.2-fix-isnan.patch?revision=1.1

Regards,
CMS Software Release Manager,
David Abdurachmanov,
CERN, CMS