[Rivet] [Rivet-svn] r4295 - in trunk: . src/Analyses

[Andy Buckley]

Hi again Hendrik,

Could you take a look at this analysis, to check if the 1.0 -> weight
changes were ok? They _look_ ok to me, but there are cases where += 1 is
the right thing to do: usually where what's being incremented is a count
which will be filled into a histo with the weight factor *after* the
incrementing.

Otherwise I think I've dealt with all the YODA TODOs, so we could make a
Rivet 2.0 release this week, giving us a lovely clean slate to work from
during the meeting next week. It's just a matter of this fix, and
whether we want to merge in (and convert) the couple of extra analyses
that were supplied in the last ~month. I think these are not essential
for the 2.0.0 release, and there may still be a call for a 1.8.4
*absolutely final* release in the 1.x series to include those analyses
at the same time as 2.0.1.

Andy


On 17/05/13 21:50, Andy Buckley wrote:
> On 17/05/13 18:36, Hendrik Hoeth wrote:
>> Thus spake blackhole at projects.hepforge.org (blackhole at projects.hepforge.org):
>>
>>> Log:
>>> Many 1.0 -> weight bugfixes in ATLAS_2011_I945498.
>>
>> I'm not sure, but this rings a bell. If I remember correcty, there was
>> some ATLAS analysis in which "1.0" actually did the right thing. It's
>> definitely worth having a look again! I'm offline this weekend, though.
> 
> Hi Hendrik,
> 
> This was reported to me in person at CERN a couple of days ago by Simon
> P's student (Johannes?) who said that changing it does fix a problem
> with weighted events. So hopefully it's the right thing to do, but I did
> just apply it blindly: it'd be great if you could take a second look :-)
> 
> Cheers (and have a good weekend!),
> Andy
> 


-- 
Dr Andy Buckley, Royal Society University Research Fellow
Particle Physics Expt Group, University of Edinburgh / PH Dept, CERN