[Rivet] Releasing Rivet 2.0

[Frank Siegert]

Hi Andy,

I have noticed another small issue in yodamerge.

Scatter2D's don't seem to have an __iadd__ but they have an __add__,
which gets used in yodamerge. The problem is, that __add__ does not
preserve the path(), instead the resulting object has an empty path.
This is then written out with the empty path to file.

I think there are two ways to fix it:
1. in yodamerge, set the path after adding.
2. in Scatter2D::add (, subtract, divide), set the path of the
returned object to the one of the first input object (and probably
check that the paths are equal).
Which would you prefer?

Also, what's the expected effect of yodamerge'ing Scatter2D's? Will it
simply add up the histo bins, which will be useless in all cases that
I can think of?

Cheers,
Frank


On 6 October 2013 21:10, Andy Buckley <andy.buckley at cern.ch> wrote:
> Hi all,
>
> Since earlier in the week, and particularly after a useful conversation
> with Frank S on Friday and some YODA merge script & Cython hacking that
> followed, I'm now feeling that the YODA and Rivet2 head versions are
> good enough for our long-planned release.
>
> That's assuming that the D0 W charge asymmetry issue that I mentioned
> before (from the H++ vaidation suite) is not actually a problem, since
> no-one responded about that.
>
> Has anyone else tried the head configuration recently? Any problems? Any
> good reasons *not* to release?
>
> If there's no opposition, I'll make a release candidate tag and tarball
> so I can do a final test on lxplus. David, could you try running your
> validation scripts on the head one last time, just to make sure that
> nothing is _crashing_? We've been through the output numbers
> sufficiently -- I just want to get good coverage to make sure that none
> of the technical stuff I did in the last 10 days broke systems other
> than mine. Once we've got the all clear, I'll tag Rivet 2.0.0 and YODA
> 1.0.3 (or 1.1.0?) and we can *finally* get this thing out!
>
> Cheers,
> Andy
>
> --
> Dr Andy Buckley, Royal Society University Research Fellow
> Particle Physics Expt Group, University of Glasgow / PH Dept, CERN
> _______________________________________________
> Rivet mailing list
> Rivet at projects.hepforge.org
> http://www.hepforge.org/lists/listinfo/rivet