|
[Rivet] Bug in CMS_2013_I1209721Piergiulio Lenzi piergiulio.lenzi at cern.chFri May 2 16:22:55 BST 2014
Dear David, thanks for your prompt reply. Looking more carefully into CMS_2013_I1209721 I found two other problems. The first is the histogram booking, which should be: // Book histograms from data for (size_t i = 0; i < 2; ++i) { _histDeltaPhiZJ1_1[i] = bookHisto1D(1+i*9, 1, 1); _histDeltaPhiZJ1_2[i] = bookHisto1D(2+i*9, 1, 1); _histDeltaPhiZJ1_3[i] = bookHisto1D(4+i*9, 1, 1); _histDeltaPhiZJ2_3[i] = bookHisto1D(5+i*9, 1, 1); _histDeltaPhiZJ3_3[i] = bookHisto1D(3+i*9, 1, 1); _histDeltaPhiJ1J2_3[i] = bookHisto1D(6+i*9, 1, 1); _histDeltaPhiJ1J3_3[i] = bookHisto1D(7+i*9, 1, 1); _histDeltaPhiJ2J3_3[i] = bookHisto1D(8+i*9, 1, 1); _histTransvThrust[i] = bookHisto1D(9+i*9, 1, 1); } currently the "+i*9" is missing and the "boosted regime" histograms are never booked (or booked incorrectly with the non-boosted regime binning) Then the part in which the momenta for the transverse thrust calculation are prepared is missing a piece // Now compute the thrust // Collect Z and jets transverse momenta to calculate transverse thrust vector<Vector3> momenta; momenta.clear(); Vector3 mom = z[0].momentum().p(); mom.setZ(0); momenta.push_back(mom); for (size_t i = 0; i < cleanedJets.size(); ++i) { Vector3 mj = cleanedJets[i]->momentum().vector3(); mj.setZ(0); momenta.push_back(mj); } // THE PART BELOW IS MISSING if (momenta.size() <= 2){ // We need to use a ghost so that Thrust.calc() doesn't return 1. momenta.push_back(Vector3(0.0000001,0.0000001,0.)); } This part is needed for a correct thust calculation in Z+1 jet events (momenta.size()=2) I'm also attaching the fixed analysis. Cheers Giulio On 01/05/2014 17:54, David Grellscheid wrote: > Hi Giulio, > > thanks for spotting this! It's fixed in the repository now. The patch > will be released in the next version and is also available at > > https://rivet.hepforge.org/hg/rivet/raw-rev/94600cbc5503 > > See you, > > David > > > On 01/05/14 16:03, Piergiulio Lenzi wrote: >> Dear Rivet developers, >> I noticed a but in CMS_2013_I1209721, >> the Z projections read: >> // Z finders for electrons and muons >> const ZFinder zfe(fs, -2.4, 2.4, 20*GeV, PID::ELECTRON, 71*GeV, >> 111*GeV); >> const ZFinder zfm(fs, -2.4, 2.4, 20*GeV, PID::ELECTRON, 71*GeV, >> 111*GeV); >> while it should be >> >> // Z finders for electrons and muons >> const ZFinder zfe(fs, -2.4, 2.4, 20*GeV, PID::ELECTRON, 71*GeV, >> 111*GeV); >> const ZFinder zfm(fs, -2.4, 2.4, 20*GeV, PID::MUON, 71*GeV, 111*GeV); >> >> Cheers >> Giulio >> _______________________________________________ >> Rivet mailing list >> Rivet at projects.hepforge.org >> https://www.hepforge.org/lists/listinfo/rivet >> -------------- next part -------------- A non-text attachment was scrubbed... Name: CMS_2013_I1209721.cc Type: text/x-c++src Size: 5738 bytes Desc: not available URL: <https://www.hepforge.org/lists-archive/rivet/attachments/20140502/04707464/attachment.cc>
More information about the Rivet mailing list |