[Rivet] Dangerous casting to FinalState

[Chris Pollard]

Hi Frank,

Actually, I think Chris has pointed that out before, and I only
> realise it now: My copying test case also fails on current Rivet tip,
> even without my patch! Are there no (other) cases, where we really
> copy projections by value?
>

I don't think so, thankfully!

So we might as well go ahead with my patch, since it will save users
> from this silly slicing mistake. And we will have to fix the
> projection registration mechanism anyway if we want to allow copying
> of projections by value. Though I didn't quite understand David's last
> comment: do you find the patch ok, or not (assuming we only care about
> FinalState-derived projections at the moment)? Any other objections?
>

I don't object to the solution per se, but my preference is to fix the
copy-by-value issue correctly throughout the Projection inheritance
hierarchy instead of patching just FinalState. If this is the solution we
choose, great, but let's fix the whole tree. Do you agree?

Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.hepforge.org/lists-archive/rivet/attachments/20150713/b34e114a/attachment.html>