[Rivet] Dangerous casting to FinalState

[Chris Pollard]

Hi Frank,

I don't see any objections, so could you include your patch and push to the
main repo? I will then run the validation tonight.

Chris

On Mon, Jul 13, 2015 at 7:35 PM, Frank Siegert <frank.siegert at cern.ch>
wrote:

> Hi Chris,
>
> >> So we might as well go ahead with my patch, since it will save users
> >> from this silly slicing mistake. And we will have to fix the
> >> projection registration mechanism anyway if we want to allow copying
> >> of projections by value. Though I didn't quite understand David's last
> >> comment: do you find the patch ok, or not (assuming we only care about
> >> FinalState-derived projections at the moment)? Any other objections?
> >
> > I don't object to the solution per se, but my preference is to fix the
> > copy-by-value issue correctly throughout the Projection inheritance
> > hierarchy instead of patching just FinalState. If this is the solution we
> > choose, great, but let's fix the whole tree. Do you agree?
>
> Sounds good to me. Do you plan to have this already for this release?
> If not, I still see no reason to not use my patch as an intermediate
> stop-gap measure, which will be amended by a solution for all
> Projections at some point.
>
> Cheers,
> Frank
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.hepforge.org/lists-archive/rivet/attachments/20150714/a69c08f6/attachment.html>