[Rivet] Patch for Rivet to automatically detect available FastJet plugins

[Andy Buckley]

On 07/04/17 18:52, cholm wrote:
> Hi David et al,
>
> On 2017-04-07 11:04, David Grellscheid wrote:
>> Hi Christian,
>>
>> thanks for the patch!
>
> You're welcome.
>
>> Are the changes to the libtool.m4 file necessary,
>> or is it just a matter of your autoreconf installing a different version
>> of libtool on top, which accidentally got picked up?
>
> The changes to libtool.m4 are not important.  They came, as you said, as
> a consequence of running autoreconf -i -f to include the changes in
> configure.ac
>
> Another thing, perhaps you should stipulate that one needs to set
> PYTHONPATH to include <prefix>/lib/python<version>/site-packages if one
> does not install in either /usr/local or ~/.local



> Also, perhaps you should consider to build the docs  (Doxygen) as part
> of the regular build.  In any case, you should change the line
>
>   @$(DOXYGEN) $(top_srcdir)/Doxyfile || true
>
> to
>
>   @$(DOXYGEN) $(top_builddir)/Doxyfile || true
>
> if one does out-of-source-directory builds (as I prefer to do - do not
> sh*t where you eat kinda policy :-)

I'm not sure I understand this -- Doxygen is run on the sources, so 
should be executed on the source dir. But I haven't run in the 
out-of-source form for some time (it used to cause major problems with 
the Python interface generation, and I stopped doing it) -- is the issue 
that the generated Doxyfile appears in the builddir? Looking inside it, 
I'm not sure that the correct source paths will be found: it looks like 
some insertions of @top_srcdir@ would be needed. Have you tried an 
out-of-source build with your suggested change and found that all is 
fine? If so, or if you needed to also tweak Doxygen.in, a separate patch 
for this specific issue would be great :-)


> And finally, you should probably automatically detect if HepMC is of the
> right version (i.e., 2.x), since HepMC 3 has changed a lot in the API.

Yes, that's in development for 2.6.0. Slow development, since the last 
few months have been very busy with non-Rivet things, but it is coming!

Andy

-- 
Dr Andy Buckley, Lecturer / Royal Society University Research Fellow
Particle Physics Expt Group, University of Glasgow