[Rivet] [Rivet-svn] rivet: fix constructor - always needs to have itself as a consti...

[Jonathan Butterworth]

CMS_2016_I1491950; a top cross section, which defines a 
"SpecialDressedLepton" projection for itself - so a bit non-standard, 
but sensible-looking as far as I could tell. The ability to create a 
DressedLepton without constituents, then query the constituents (without 
any protection) led to the crash...

Cheers,
Jon

On 05/03/2018 17:39, Andy Buckley wrote:
> Thanks. Do you remember which one? This should only be visible to the
> DressedLeptons class, which was validated for the original form... so
> this update may be double-counting the bare lepton for all other
> analyses at the moment. I'd like to take a look and see if this analysis
> is doing something special with DressedLepton.
>
> Cheers,
> Andy
>
> *Dr Andy Buckley, Lecturer / Royal Society University Research Fellow*
> Particle Physics Experiment Group, University of Glasgow
> 	
>
> On Mar 4 2018, at 12:25 pm, Jonathan Butterworth
> <J.Butterworth at ucl.ac.uk> wrote:
>
>
>     Ok. I fixed it because it was causing an uncontrolled crash in one of
>     the contrib CMS routines...
>
>     On 02/03/2018 17:18, Andy Buckley wrote:
>
>         I have a funny feeling that I didn't do that on purpose, but can't
>         remember the exact motivation now... should have put it in a
>         comment.
>         Hmm, one to look out for in the next pre-release tests.
>
>         More generally, I would like to eliminate the DressedLepton
>         class and
>         just use Particle for that purpose, now that it can have
>         constituents.
>         And also unify the Particle and Jet a bit better, since both
>         will have
>         constituents... and it could be useful to use jets as inputs to
>         FastJets
>         for ATLAS-style reclustering.
>
>         Andy
>
>         *Dr Andy Buckley, Lecturer / Royal Society University Research
>         Fellow*
>         Particle Physics Experiment Group, University of Glasgow
>
>
>         On Feb 27 2018, at 11:15 pm, Rivet Mercurial
>         <rivet at projects.hepforge.org> wrote:
>
>
>         details: https://rivet.hepforge.org/hg/rivet/rev/b4200fb4a998
>         branches: release-2-6-x
>         changeset: 6245:b4200fb4a998
>         user: Jon Butterworth <j.butterworth at cern.ch>
>         date: Tue Feb 27 22:34:33 2018 +0000
>         description:
>         fix constructor - always needs to have itself as a constituent
>
>         diffs (13 lines):
>
>         --- a/src/Projections/DressedLeptons.cc Thu Feb 22 16:09:31 2018
>         +0000
>         +++ b/src/Projections/DressedLeptons.cc Tue Feb 27 22:34:33 2018
>         +0000
>         @@ -9,7 +9,9 @@
>
>         DressedLepton::DressedLepton(const Particle& dlepton)
>         : Particle(dlepton)
>         - { }
>         + {
>         + setConstituents({{dlepton}}); //< bare lepton is first constituent
>         + }
>
>         DressedLepton::DressedLepton(const Particle& lepton, const
>         Particles& photons, bool momsum)
>         : Particle(lepton.pid(), lepton.momentum())
>         _______________________________________________
>         Rivet-svn mailing list
>         Rivet-svn at projects.hepforge.org
>         https://www.hepforge.org/lists/listinfo/rivet-svn
>
>
>     --
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     Prof. Jonathan Butterworth, http://www.hep.ucl.ac.uk/~jmb/
>     Head, Physics and Astronomy Department Tel: +44 20 7679 3444
>     University College London Gower St, London WC1E 6BT, UK
>     ATLAS, CERN Tel: +41 22 76 72340
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Prof. Jonathan Butterworth,              http://www.hep.ucl.ac.uk/~jmb/
Head, Physics and Astronomy Department            Tel: +44 20 7679 3444
University College London                 Gower St, London WC1E 6BT, UK
ATLAS, CERN                                       Tel: +41 22 76  72340
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~