[Rivet] LeadingParticlesFinalState

[Andy Buckley]

Frank Siegert wrote:
> Hi Riveters,
> 
> The LeadingParticlesFinalState projection seems to have a major bug: It's 
> constructor allows for mineta, maxeta and minpT arguments, which never get 
> used. Some analyses rely on these arguments in the constructor, so this 
> will actually have an impact I believe.
> 
> I suggest removing these arguments from the constructor and require that 
> all cuts are specified in the FS that is passed to LPFS. Such a change in 
> the affected analyses would look like:
> 
> -  LeadingParticleFinalState lpfs(fs, -1.0, 1.0, 30.0*GeV)
> +  LeadingParticleFinalState lpfs(FinalState(-1.0, 1.0, 30.0*GeV))
> 
> (assuming the fs was less restrictive).

I remember seeing this before and then forgetting to do anything about 
it. Yes, I think it's at least a design bug, and if the arguments aren't 
being used then it's a behavioural bug as well. Please change it!

Andy

-- 
Dr Andy Buckley
SUPA Advanced Research Fellow
Particle Physics Experiment Group, University of Edinburgh