|
[Rivet] YODA developmentFrank Siegert frank.siegert at durham.ac.ukMon Nov 2 17:20:57 GMT 2009
Andy Buckley, Thursday 29 October 2009: > * Check out the code and see if you can build and install it. There > are no dependencies. It worked for Eike, but you never know! I had to fix two issues to make YODA itself compile, have committed them. I didn't think I had such an unusual setup, so how come it worked for everybody else? Now when I want to link against it, I notice that the headers don't get installed in $prefix/include/YODA, but directly into $prefix/include. This breaks even the included Test1.cc and Test2.cc. The most elegant fix that I can think of, is to replace "Yoda" -> "YODA" in AC_INIT and then use pkginclude_HEADERS instead of include_HEADERS in include/YODA/Makefile.am. Just wanted to ask here first before I commit this. > * Try running some of the test scripts and programs in the tests > directory. Have a look at the code and comment on whether you think the > API sucks or can be improved in small ways. Minor comment on the API: Is there any reason why you prefer to duplicate methods e.g. in Histo1D constructors with and without "path" and "title" arguments, instead of using default values for them? Does that make it easier for the Python bindings? > Please ask if there are any questions, and use the tracker and the YODA > mailing list (join it!) to coordinate who's doing what. Hopefully I can > answer any questions about the existing code... Your thread with Ben seems to be producing emails quicker than I can digest them (somebody complain about the length of my emails/threads ever again!). I'll try to answer them there when I come across a question or comment. Frank
More information about the Rivet mailing list |