[Rivet] [Rivet-svn] r2055 - trunk/src/Analyses

[Andy Buckley]

blackhole at projects.hepforge.org wrote:
> Author: fsiegert
> Date: Sun Nov 15 22:32:17 2009
> New Revision: 2055
> 
> Log:
> I'm not familiar with the details of this analysis, but it seems unlikely to me that any (profile)histogram should be filled without weight, otherwise it can't be used for weighted analyses. And I see very strange distributions in those 6 plots when I run with weighted events.
> I hope this is the correct fix, but Andy/Holger: Could you please check that I haven't done something completely stupid? Thanks.
> 
> Modified:
>    trunk/src/Analyses/CDF_2001_S4751469.cc
> 
> Modified: trunk/src/Analyses/CDF_2001_S4751469.cc
> ==============================================================================
> --- trunk/src/Analyses/CDF_2001_S4751469.cc	Wed Nov 11 16:22:56 2009	(r2054)
> +++ trunk/src/Analyses/CDF_2001_S4751469.cc	Sun Nov 15 22:32:17 2009	(r2055)
> @@ -183,16 +183,16 @@
>        // Update the "proper" dphi profile histograms
>        for (int i= 0; i < 50; i++) {
>          if (ptLead/GeV > 2.0) {
> -          _numvsDeltaPhi2->fill(hist_num_dphi_2.binMean(i), hist_num_dphi_2.binHeight(i));
> -          _pTvsDeltaPhi2->fill(hist_pt_dphi_2.binMean(i), hist_pt_dphi_2.binHeight(i)); 
> +          _numvsDeltaPhi2->fill(hist_num_dphi_2.binMean(i), hist_num_dphi_2.binHeight(i), weight);
> +          _pTvsDeltaPhi2->fill(hist_pt_dphi_2.binMean(i), hist_pt_dphi_2.binHeight(i), weight); 
>          }
>          if (ptLead/GeV > 5.0) {
> -          _numvsDeltaPhi5->fill(hist_num_dphi_5.binMean(i), hist_num_dphi_5.binHeight(i));
> -          _pTvsDeltaPhi5->fill(hist_pt_dphi_5.binMean(i), hist_pt_dphi_5.binHeight(i));
> +          _numvsDeltaPhi5->fill(hist_num_dphi_5.binMean(i), hist_num_dphi_5.binHeight(i), weight);
> +          _pTvsDeltaPhi5->fill(hist_pt_dphi_5.binMean(i), hist_pt_dphi_5.binHeight(i), weight);
>          }
>          if (ptLead/GeV > 30.0) {
> -          _numvsDeltaPhi30->fill(hist_num_dphi_30.binMean(i), hist_num_dphi_30.binHeight(i));
> -          _pTvsDeltaPhi30->fill(hist_pt_dphi_30.binMean(i), hist_pt_dphi_30.binHeight(i));
> +          _numvsDeltaPhi30->fill(hist_num_dphi_30.binMean(i), hist_num_dphi_30.binHeight(i), weight);
> +          _pTvsDeltaPhi30->fill(hist_pt_dphi_30.binMean(i), hist_pt_dphi_30.binHeight(i), weight);
>          }
>        }

Hi Frank,

Yes, you're right, those "final" profile fills should be weighted. The 
temporary histos used to generate the per-event profile entries aren't 
weighted (otherwise there would be a double-weighting) and I guess I 
just forgot to add the weighting when copy 'n' pasting. Thanks ;)

Andy

-- 
Dr Andy Buckley
SUPA Advanced Research Fellow
Particle Physics Experiment Group, University of Edinburgh

The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.