[Rivet] [Rivet-svn] r2055 - trunk/src/Analyses

[Frank Siegert]

Andy Buckley, Monday 16 November 2009:
> blackhole at projects.hepforge.org wrote:
> > Author: fsiegert
> > Date: Sun Nov 15 22:32:17 2009
> > New Revision: 2055
> >
> > Log:
> > I'm not familiar with the details of this analysis, but it seems
> > unlikely to me that any (profile)histogram should be filled without
> > weight, otherwise it can't be used for weighted analyses. And I see
> > very strange distributions in those 6 plots when I run with weighted
> > events. I hope this is the correct fix, but Andy/Holger: Could you
> > please check that I haven't done something completely stupid? Thanks.
> >
> > Modified:
> >    trunk/src/Analyses/CDF_2001_S4751469.cc
> 
> Yes, you're right, those "final" profile fills should be weighted. The
> temporary histos used to generate the per-event profile entries aren't
> weighted (otherwise there would be a double-weighting) and I guess I
> just forgot to add the weighting when copy 'n' pasting. Thanks ;)

Thanks for checking. Taking this as a reason, I propose to remove the 
default arguments for weight from the histogram fill method. If there are 
no objections, I would commit that tomorrow.

Frank