|
[Rivet] ATLAS inel modified versionAndy Buckley andy.buckley at ed.ac.ukTue Dec 11 15:34:10 GMT 2012
On 11/12/12 01:51, Sercan Sen wrote: > > Hello Andy, > > Attached is the modified version of the ATLAS inelastic routine. It > gives the same results with the previous one which is available in Rivet > 1.8.2.beta, however, this one is written in a more C++/Rivet way > concerning your latest comments. Thanks Sercan, I've merged and committed this now. I slightly modified the M2 calculation at the end, to use std::max(x, y) rather than "(x > y) ? x : y" and to mostly avoid using variables with MixedCase naming that looks like a class name (see https://rivet.hepforge.org/trac/wiki/CodingStyleGuide ). There were also a couple of places where temporary variables could be removed without affecting readability, so I did that. Thanks also for clearing up the /GeV issues! Cheers, Andy -- Dr Andy Buckley, SUPA Advanced Research Fellow Particle Physics Expt Group, University of Edinburgh The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.
More information about the Rivet mailing list |